randogoth/swarm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Bound the relay connect handshake so a fetch can't hang forever

Browse source
This commit is contained in:
randogoth 2026-07-05 16:50:28 +03:00
parent 0e70aba755
commit 60f9e4ccfa
3 changed files with 41 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

28
test/nostr_fetch_actor_test.dart
View file

@ -120,6 +120,34 @@ void main() {
expect((result as EventsFetched).events, hasLength(1));
});
test('bounds a hung connect so the fetch cannot stall forever', () async {
final fakeHang = FakeRelayConnection()..hangOnConnect = true;
final fakeUp = FakeRelayConnection();
addTearDown(fakeHang.dispose);
addTearDown(fakeUp.dispose);
final event = _makeEvent('id1');
fakeUp.onReq = (subId) {
fakeUp.push(jsonEncode(['EVENT', subId, event]));
fakeUp.push(jsonEncode(['EOSE', subId]));
};
final fakes = {'ws://hang': fakeHang, 'ws://up': fakeUp};
final actor = NostrFetchActor(
relayUrls: ['ws://hang', 'ws://up'],
connectDeadline: const Duration(milliseconds: 50),
connectionFactory: (url) => fakes[url]!,
);
// The outer timeout is a guard: without the connect deadline this hangs.
final result = await actor
.handle(const FetchEvents(_filter))
.timeout(const Duration(seconds: 2));
expect(result, isA<EventsFetched>());
expect((result as EventsFetched).events, hasLength(1));
});
test('sends CLOSE after EOSE', () async {
final fake = FakeRelayConnection();
addTearDown(fake.dispose);